Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RenameCollection API #425

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

congqixia
Copy link
Contributor

/kind enhancement
Resolves #423

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Mar 17, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby March 17, 2023 03:30
@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #425 (403e7ca) into master (01b5dd8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   87.44%   87.49%   +0.04%     
==========================================
  Files          30       30              
  Lines        2804     2815      +11     
==========================================
+ Hits         2452     2463      +11     
  Misses        267      267              
  Partials       85       85              
Impacted Files Coverage Δ
client/client.go 75.80% <ø> (ø)
client/client_grpc_collection.go 88.05% <100.00%> (+0.51%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Mar 17, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

return ErrClientNotReady
}

if err := c.checkCollectionExists(ctx, collName); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this to RenameCollection

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 17, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 61f82a9 into milvus-io:master Mar 17, 2023
@congqixia congqixia deleted the add_rename_api branch June 13, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add rename collection API
3 participants