-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RenameCollection API #425
Conversation
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 87.44% 87.49% +0.04%
==========================================
Files 30 30
Lines 2804 2815 +11
==========================================
+ Hits 2452 2463 +11
Misses 267 267
Partials 85 85
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
return ErrClientNotReady | ||
} | ||
|
||
if err := c.checkCollectionExists(ctx, collName); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave this to RenameCollection
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind enhancement
Resolves #423